Adding service mesh annotations #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding annotations to deployments to inject istio sidecar container when the namespace is included in the service mesh Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
servicemesh
branch
from
e169080 to
218efb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adding annotations to deployments to inject istio sidecar container when the namespace is included in the service mesh.
Just FYI, apart from these annotations, the
netperfnamespace needs to have an special label to be included in the servicemesh as well, so it's possible to opt-in/out k8s-netperf pods from ServiceMesh when neededRelated Tickets & Documents
Checklist before requesting a review