Add more validation and local fix #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sejug was testing microshift he found some corner cases I didn't have code for... Fixing that! Signed-off-by: Joe Talerico <[email protected]>
jtaleric
force-pushed
the
check-for-num-nodes
branch
from
116cd80 to
12f7476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
When sejug was testing microshift he found some corner cases I didn't have code for... Fixing that!
--localwas also broken due to incorrect podAffinity, cleaning that up.Related Tickets & Documents
Checklist before requesting a review
Testing