Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Microshift #128

Closed
wants to merge 1 commit into from
Closed

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Jan 5, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Attempting to fix prom queries w/ microshift

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Attempting to fix prom queries w/ microshift

Signed-off-by: Joe Talerico <[email protected]>
@sjug
Copy link

sjug commented Jan 5, 2024

It seems that OpenShift only relabels the node_cpu_seconds_total query and that requires the check in QueryNodeCPU() however the container_cpu_usage_seconds_total instance isn't relabeled and has the IP address instead.

I will just change my MicroShift prometheus config to use IP addresses only rather than the hostname. Appreciate the support @jtaleric!

@sjug sjug closed this Jan 5, 2024
@jtaleric jtaleric deleted the microshift branch January 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants