Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report avg from processes latency #148

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

venkataanil
Copy link
Contributor

super-netperf script runs multiple netperf processes. Each process provides average latency and P99 latency as output. For reporting, this script calculates average from all of the processes latency. Calculating P99 latency from all the P99 latencies is difficult in bash script. Instead we are calculating average from all the P99 latencies similar to what ingress-perf does.

So the report will have

  1. Average of average latencies
  2. Average of P99 latencies

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

super-netperf script runs multiple netperf processes. Each process
provides average latency and P99 latency as output.
For reporting, this script calculates average from all of the
processes latency. Calculating P99 latency from all the P99
latencies is difficult in bash script. Instead we are calculating
average from all the P99 latencies similar to what ingress-perf
does.

So the report will have
1. Average of average latencies
2. Average of P99 latencies

Signed-off-by: venkataanil <[email protected]>
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane to me, thanks @venkataanil !!

Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good catch!

@rsevilla87 rsevilla87 added the bug Something isn't working label Jun 21, 2024
@rsevilla87 rsevilla87 merged commit da7c88b into cloud-bulldozer:main Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants