Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding podMem #155

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Adding podMem #155

merged 5 commits into from
Nov 18, 2024

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Oct 23, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding the podMem similar to the podCPU to our csv/result data

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@jtaleric
Adding podMem
9a31f8b 
Adding the podMem similar to the podCPU to our csv/result data

Signed-off-by: Joe Talerico aka rook <[email protected]>
@jtaleric
Fixing mem query, adding vswitchd
9f12223 
Signed-off-by: Joe Talerico aka rook <[email protected]>
@jtaleric
Adding vswitch data
eada105 
Signed-off-by: Joe Talerico aka rook <[email protected]>
mohit-sheth
mohit-sheth approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@mohit-sheth mohit-sheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rsevilla87
rsevilla87 reviewed Nov 15, 2024
View reviewed changes
pkg/metrics/system.go Outdated Show resolved Hide resolved
rsevilla87
rsevilla87 reviewed Nov 15, 2024
View reviewed changes
pkg/metrics/system.go Outdated Show resolved Hide resolved
rsevilla87
rsevilla87 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jtaleric and others added 2 commits November 15, 2024 13:50
@jtaleric @rsevilla87
Update pkg/metrics/system.go
2cf30f6 
Co-authored-by: Raúl Sevilla <[email protected]>
@jtaleric @rsevilla87
Update pkg/metrics/system.go
e40f137 
Co-authored-by: Raúl Sevilla <[email protected]>
@rsevilla87 rsevilla87 merged commit bb7c578 into cloud-bulldozer:main Nov 18, 2024
5 checks passed
@jtaleric jtaleric deleted the add-pod-mem branch November 18, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohit-sheth mohit-sheth mohit-sheth approved these changes

@rsevilla87 rsevilla87 rsevilla87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtaleric @rsevilla87 @mohit-sheth