set expiration_timestamp for cluster #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sets expiration_timestamp for the clusters created by clusters_mgmt endpoints. We need to work on fixing [1] i.e setting expiration_timestamp for clusters created by services (i.e service_mgmt endpoint). We will disable testing service_mgmt endpoints in CI till this gets fixed. [1] cloud-bulldozer#102
venkataanil
requested review from
chentex,
dry923,
krishvoor,
mukrishn and
morenod
mukrishn
approved these changes
Dec 8, 2022
krishvoor
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sets expiration_timestamp for the clusters created by clusters_mgmt endpoints. We need to work on fixing [1] i.e setting expiration_timestamp for clusters created by services (i.e service_mgmt endpoint). We will disable testing service_mgmt endpoints in CI till this gets fixed.
[1] #102