Skip to content

Commit

Permalink
Fixing Orion ack
Browse files Browse the repository at this point in the history
Missing 4.17 configs
Fix 4.19 crd file name
Fix missing check for length (causing backtrace).

Signed-off-by: Joe Talerico aka rook <[email protected]>
  • Loading branch information
jtaleric committed Dec 24, 2024
1 parent a0d1e02 commit ffaf0ef
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 2 deletions.
1 change: 1 addition & 0 deletions ack/4.17_cluster-density_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
1 change: 1 addition & 0 deletions ack/4.17_crd-scale_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
1 change: 1 addition & 0 deletions ack/4.17_node-density_ack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
11 changes: 10 additions & 1 deletion ack/4.18_cluster-density_ack.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,13 @@
ack:
- uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
metric: etcdCPU_avg
reason: "Below 10%"
reason: "Below 10%"
- uuid: 4eeee274-53ac-4e75-855f-139dc743606b
metric: kubelet_avg
reason: "Started thread with node team"
- uuid: 22e90f4e-1c79-4d9d-b2f6-b95a7072738c
metric: kubelet_avg
reason: "Tooling issue - kubeburner"
- uuid: 22e90f4e-1c79-4d9d-b2f6-b95a7072738c
metric: ovnCPU_avg
reason: "Tooling issue - kubeburner"
File renamed without changes.
3 changes: 2 additions & 1 deletion pkg/algorithms/edivisive/edivisive.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ def _analyze(self):
if len(self.options["ack"]) > 1 and self.options["ackMap"] is not None:
for ack in self.options["ackMap"]["ack"]:
pos = series.find_by_attribute("uuid",ack["uuid"])
ackSet.add(str(pos[0]) + "_" + ack["metric"])
if len(pos) > 0 :
ackSet.add(str(pos[0]) + "_" + ack["metric"])

# filter by direction and ack'ed issues
for metric, changepoint_list in change_points_by_metric.items():
Expand Down

0 comments on commit ffaf0ef

Please sign in to comment.