Adding baseline and uuid options #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shashank-boyapally @jtaleric PTAL and let me know your thoughts on this change. Would allow for a user to set a uuid on the command line instead of filling out the metadata of it in a yaml file. Think this would be helpful for our CI runs that would just be able to set uuid, it'll fetch the metadata of that uuid, find any comparison uuid(s) and run the metric collection/comparison on it. |
paigerube14
force-pushed
the
uuid
branch
3 times, most recently
from
9a05a85 to
cb1424c
Compare
|
/assign @shashank-boyapally |
jtaleric
reviewed
Mar 11, 2024
paigerube14
force-pushed
the
uuid
branch
3 times, most recently
from
6fb50ad to
366fc6d
Compare
|
@shashank-boyapally any final thoughts on this? |
Signed-off-by: Paige Rubendall <[email protected]>
|
/lgtm, Great work @paigerube14!! |
Signed-off-by: Paige Rubendall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
A lot of the times we have a set uuid (current run) or one in mind that it would be nice to not have to go get the metadata of the run, create a config file and then run. This would allow a user to set a uuid on command line and have the config file only define the metrics wanted to be collected
Related Tickets & Documents
Checklist before requesting a review
Testing
Example:
orion --uuid dc9431e4-43c9-482d-861b-87ab11afbd3a --baseline 2076cfe3-00fc-4fdd-bf76-016bb31264f1