Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd templating #56

Merged

Conversation

shashank-boyapally
Copy link
Contributor

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Added templating to cmd mode.. to be merged after refactor PR #55

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@vishnuchalla vishnuchalla mentioned this pull request Aug 1, 2024
7 tasks
@shashank-boyapally shashank-boyapally marked this pull request as ready for review August 1, 2024 17:24
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
pkg/config.py Outdated
template = Template(template_content)
rendered_config_yaml = template.render(merged_parameters)
rendered_config = yaml.safe_load(rendered_config_yaml)
print(rendered_config)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this debug statement be removed please?

Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit 4a48d24 into cloud-bulldozer:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants