Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI test #58

Closed
wants to merge 3 commits into from
Closed

Adding CI test #58

wants to merge 3 commits into from

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Aug 1, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding CI tests for orion. They will be triggered against each PR and will help us catch issues early.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested in local. Attempting to test it from the PR as well.

@jtaleric
Copy link
Member

jtaleric commented Aug 1, 2024

Can you add more to the description here? Looking at things, the test just runs orion cmd --help curious if you plan to expand on that for functional testing? Thanks for adding this!!

Vishnu Challa added 2 commits August 1, 2024 14:18
@vishnuchalla
Copy link
Collaborator Author

Can you add more to the description here? Looking at things, the test just runs orion cmd --help curious if you plan to expand on that for functional testing? Thanks for adding this!!

Yes I am try to add as many tests as I can through this PR. Please be patient until I tag for a review. Running into some issues while fetching secrets at the moment. Need a bit of experimentation.

@vishnuchalla
Copy link
Collaborator Author

Closing this PR in favor of #59 as secrets are not accessible from a fork for the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants