Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acking the 4.18 and 4.19 issues #81

Merged
merged 2 commits into from
Dec 18, 2024
Merged

acking the 4.18 and 4.19 issues #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0395130
acking the 4.18 and 4.19 issues
jtaleric Dec 17, 2024
afbef21
Merge branch 'main' into ack-current
jtaleric Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ack/4.18_cluster-density_ack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
ack:
- uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
metric: etcdCPU_avg
reason: "Below 10%"
1 change: 1 addition & 0 deletions ack/4.18_crd-scale_ack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
5 changes: 5 additions & 0 deletions ack/4.18_node-density_ack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
ack:
- uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
metric: etcdCPU_avg
reason: "Below 10%"
5 changes: 5 additions & 0 deletions ack/4.19_cluster-density_ack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
ack :
- uuid: cfae6e1e-8c47-4628-be52-8705c8c64285
metric: kubelet_avg
reason: "kube-burner change which increased cpu for kubelet, it was reverted."
1 change: 1 addition & 0 deletions ack/4.19_crd-scale_ack .yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
1 change: 1 addition & 0 deletions ack/4.19_node-density_ack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---
2 changes: 1 addition & 1 deletion pkg/algorithms/edivisive/edivisive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def _analyze(self):

# Process if we have ack'ed regression
ackSet = set()
if len(self.options["ack"]) > 1 :
if len(self.options["ack"]) > 1 and self.options["ackMap"] is not None:
for ack in self.options["ackMap"]["ack"]:
pos = series.find_by_attribute("uuid",ack["uuid"])
ackSet.add(str(pos[0]) + "_" + ack["metric"])
Expand Down
Loading