Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workload summary and compare data graphs on k8s-netperf #106

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

morenod
Copy link
Collaborator

@morenod morenod commented Jan 5, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding a new variable, compare by, to be used on the new graphs, to compare results by UUID, cluster Name, or OCP Version

image

Adding a table at the top with global information about the execution selected, like

image

Adding bar graphs for comparing results between one or more executions, with the information we provide on the result reports, like:

Node to Node
Pod to Pod
Pod to Pod via service

image

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@smalleni
Copy link
Collaborator

smalleni commented Jan 9, 2024

@jtaleric review please.

@jtaleric
Copy link
Member

@morenod Awesome improvement!

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we just need to rebase w/ main before we merge.

@morenod
Copy link
Collaborator Author

morenod commented Jan 16, 2024

@jtaleric rebased

@rsevilla87 rsevilla87 self-requested a review January 16, 2024 10:11
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new panels, lgtm!

@rsevilla87 rsevilla87 merged commit d1fc8e0 into cloud-bulldozer:master Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants