Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old code and keeping only latest grafonnet dashboards #125

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Jul 27, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Removing old grafonnet code and keeping only the latest library code.

Followup item

To update make command in internal grafana jump host so that it compiles and build latest dashboards.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested in local using dittybopper setup command in README.md
link: http://dittybopper-dittybopper.apps.ols-perf-test.perfscale.devcluster.openshift.com/?orgId=1

Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@afcollins afcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it works, but I didn't test building a new syncer image and deploying it locally.

@vishnuchalla
Copy link
Collaborator Author

Tested and verified locally. Works fine.

@vishnuchalla vishnuchalla merged commit c310d6a into cloud-bulldozer:master Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants