Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct query and graph name #130

Merged
merged 1 commit into from
Sep 25, 2024
Merged

correct query and graph name #130

merged 1 commit into from
Sep 25, 2024

Conversation

qiliRedHat
Copy link
Contributor

@qiliRedHat qiliRedHat commented Aug 29, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

  1. The graph name 'request duration - 99th quantile' is not correctly match to the actual query.
  2. Update ovnkube-master to ovnkube-control-plane

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

vishnuchalla
vishnuchalla approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm.
@mohit-sheth can you confirm that this doesn't break anything please?

@qiliRedHat
Copy link
Contributor Author

@rsevilla87 @mohit-sheth Please help to review this again after my change. Thanks.

venkataanil
venkataanil approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@venkataanil venkataanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't brake anything. We can merge it.

rsevilla87
rsevilla87 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit 9325353 into cloud-bulldozer:master Sep 25, 2024
2 checks passed
@afcollins afcollins mentioned this pull request Sep 25, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsevilla87 rsevilla87 rsevilla87 approved these changes

@venkataanil venkataanil venkataanil approved these changes

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@mohit-sheth mohit-sheth Awaiting requested review from mohit-sheth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiliRedHat @rsevilla87 @venkataanil @vishnuchalla