-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial changes for dashboards automation #78
Conversation
8a4f4a6
to
e33636a
Compare
e33636a
to
7ecdf68
Compare
dashboard=$(cat ${full_path}); | ||
for t in rendered/**/*.json; do | ||
echo "Importing ${t}"; | ||
dashboard=$(cat ${t}); | ||
echo "{\"dashboard\": ${dashboard}, \"overwrite\": true}" | | ||
curl -k -Ss -XPOST -H "Content-Type: application/json" -H "Accept: application/json" -d@- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The internal grafana won't be accessible from outside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Those actions in workflows are not of any use right now. They just help us to do some sanity checks, if we are able to build jsons and deploy them into grafana. To start with lets keep it that way and our plan is to extend the same actions for our automatic deployments in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is now this workflow is gonna fail, is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is expected and I am planning to take it outside of this PR scope. It has been failing since a while: https://github.com/cloud-bulldozer/performance-dashboards/actions/runs/6252714644/job/16976553973 as github actions won't be able to reach our observability cluster.
7ecdf68
to
c61457a
Compare
c61457a
to
f504c80
Compare
Modified: Internal logic for creating/updating dashboards Deleted: Removed old logic as it is not flexible for automation
f504c80
to
2321a75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Type of change
Added: Support for multiple multiple folders, python client
Modified: Internal logic for creating/updating dashboards
Deleted: Removed old logic as it is not flexible for automation
Description
As an initial step in our plan to automating dashboards. Adding support for multiple folders and integrating python client for ease of maintenance.
Related Tickets & Documents
Checklist before requesting a review
Testing
Tested in the local environment, using the same old methodology.
make
to generate therendered
folderdittybopper/syncer/deploy.sh
.