Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial changes for dashboards automation #78

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Sep 16, 2023

Type of change

Added: Support for multiple multiple folders, python client
Modified: Internal logic for creating/updating dashboards
Deleted: Removed old logic as it is not flexible for automation

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

As an initial step in our plan to automating dashboards. Adding support for multiple folders and integrating python client for ease of maintenance.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested in the local environment, using the same old methodology.

  • make to generate the rendered folder
  • Built syncer image following the steps in README.md
  • And finally ran dittybopper/syncer/deploy.sh.

dashboard=$(cat ${full_path});
for t in rendered/**/*.json; do
echo "Importing ${t}";
dashboard=$(cat ${t});
echo "{\"dashboard\": ${dashboard}, \"overwrite\": true}" |
curl -k -Ss -XPOST -H "Content-Type: application/json" -H "Accept: application/json" -d@-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal grafana won't be accessible from outside

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Those actions in workflows are not of any use right now. They just help us to do some sanity checks, if we are able to build jsons and deploy them into grafana. To start with lets keep it that way and our plan is to extend the same actions for our automatic deployments in future.

Copy link
Member

@rsevilla87 rsevilla87 Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is now this workflow is gonna fail, is that expected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is expected and I am planning to take it outside of this PR scope. It has been failing since a while: https://github.com/cloud-bulldozer/performance-dashboards/actions/runs/6252714644/job/16976553973 as github actions won't be able to reach our observability cluster.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Modified: Internal logic for creating/updating dashboards
Deleted: Removed old logic as it is not flexible for automation
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rsevilla87 rsevilla87 merged commit 779b567 into cloud-bulldozer:master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants