Adding k8s-netperf in grafonnet #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified: Internal logic for creating/updating dashboards Deleted: Removed old logic as it is not flexible for automation
vishnuchalla
requested review from
afcollins,
jtaleric,
rsevilla87,
smalleni,
dry923 and
smandaRH
|
@jtaleric Requesting a review on these updated changes. We do have everything in the new grafonnet library except for these two attributes: https://github.com/grafana/grafonnet/pull/140/files that I am trying to get added in the upstream schema. |
jtaleric
reviewed
Nov 13, 2023
jtaleric
approved these changes
Nov 30, 2023
Can you elaborate on the specifics please, so that I can make note of it and get it added in the upcoming PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Upstream code change for missing bits: grafana/grafonnet#140
Adding k8s-netperf dashboard in grafonnet.
Related Tickets & Documents
Checklist before requesting a review
Testing
Tested using v2 instructions in Makefile.