Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ingress dashboard to grafonnet #85

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

smanda99
Copy link
Collaborator

@smanda99 smanda99 commented Oct 13, 2023

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding ingress-performance dashboard in grafonnet.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@krishvoor
Copy link
Member

Hi @Manda-supraja26 👋
While we review your first PR to cloud-bulldozer, it would lot easier for us to reference the panels and stuff from Grafana Report, can you share your Grafana Report link URL?

@smanda99
Copy link
Collaborator Author

Hello @krishvoor 👋,
you can find the Grafana Report for the Ingress Performance at the following link: Ingress-perf Grafana Report

@smanda99 smanda99 self-assigned this Nov 17, 2023
@rsevilla87 rsevilla87 added the enhancement New feature or request label Nov 17, 2023
@vishnuchalla
Copy link
Collaborator

Hello @krishvoor 👋, you can find the Grafana Report for the Ingress Performance at the following link: Ingress-perf Grafana Report

@rsevilla87 @krishvoor Any thoughts one these new visualizations?

@vishnuchalla
Copy link
Collaborator

@Manda-supraja26 I guess it needs rebase

@smanda99
Copy link
Collaborator Author

@Manda-supraja26 I guess it needs rebase

@vishnuchalla sure, i will do it

Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Manda-supraja26, I recently added a couple of new panels to the original ingress-perf dashboard to track the CPU usage of some infrastructure components, could you add them?? thanks!

image

@smanda99
Copy link
Collaborator Author

Hey @Manda-supraja26, I recently added a couple of new panels to the original ingress-perf dashboard to track the CPU usage of some infrastructure components, could you add them?? thanks!

image

Hi @rsevilla87, I will update the dashboard as requested. Thanks!

@smanda99
Copy link
Collaborator Author

smanda99 commented Jan 8, 2024

current dashboard: Ingress-Perf

Jsonnet coded dashboard: Ingress-perf

@rsevilla87 rsevilla87 self-requested a review January 8, 2024 11:16
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vishnuchalla vishnuchalla merged commit fdf26ce into cloud-bulldozer:master Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants