start e2e before all clusters are ready #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently watcher will wait for all clusters to move to ready state and once it happens then notifies all threads to run e2e testing. If the user wants the created threads to start e2e before all clusters are moved to ready state, he can create a file named "e2e" dynamically in test directory. Watcher will check for this file and notify all threads to start running e2e tests. With this new change, e2e testing will start in either 1. all clusters moved to ready state 2. or user created a file name "e2e" in test directory i.e /tmp/<uuid>/e2e
mukrishn
approved these changes
Mar 30, 2023
|
What are the next steps for this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently watcher will wait for all clusters to move to ready state and once it happens then notifies all threads to run e2e testing. If the user wants the created threads to start e2e before all clusters are moved to ready state, he can create a file named "e2e" dynamically in test directory. Watcher will check for this file and notify all threads to start running e2e tests.
With this new change, e2e testing will start in either
Fixes
#126