-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch-dsl refactor, unit test, config update #18
Conversation
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits in the test script, but overall looks good.
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didnt have chance to fully test, things look good to me from a code level
Type of change
Description
I have integrated elasticsearch-dsl library such that there is better code readabilty and more abstraction to our queries. One change included in the following iteration is regarding config files which are sent by orion.
the above config when translated gives a
"not" list
, at the moment this list is a list of dictionaries, with each dictionary having only onekey:value
pair. The change implemented now takes in the not list as a dictionary with multiplekey:value
pairsRelated Tickets & Documents
Checklist before requesting a review
Testing