Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch-dsl refactor, unit test, config update #18

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

shashank-boyapally
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

I have integrated elasticsearch-dsl library such that there is better code readabilty and more abstraction to our queries. One change included in the following iteration is regarding config files which are sent by orion.

metrics : 
    - name:  podReadyLatency
      metricName: podLatencyQuantilesMeasurement
      quantileName: Ready
      metric_of_interest: P99
      not: 
      - jobConfig.name: "garbage-collection"

the above config when translated gives a "not" list, at the moment this list is a list of dictionaries, with each dictionary having only one key:value pair. The change implemented now takes in the not list as a dictionary with multiple key:value pairs

metrics : 
    - name:  podReadyLatency
      metricName: podLatencyQuantilesMeasurement
      quantileName: Ready
      metric_of_interest: P99
      not: 
          jobConfig.name: "garbage-collection"

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Unit tests coverage of 100%
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
fmatch/test_fmatch.py Outdated Show resolved Hide resolved
fmatch/test_fmatch.py Outdated Show resolved Hide resolved
fmatch/test_fmatch.py Outdated Show resolved Hide resolved
fmatch/test_fmatch.py Outdated Show resolved Hide resolved
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits in the test script, but overall looks good.

Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt have chance to fully test, things look good to me from a code level

@jtaleric jtaleric merged commit ff516c7 into cloud-bulldozer:main Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants