Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated postgis from 2.5 to 3.3.2 and fix bugs after updated #3

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

August-beaulo
Copy link

--fix #2 postgis 2.5 branch has ended its life two years ago


Change logs

  1. Updated postgis from 2.5.4 to 3.3.2.
  2. Fix orca job failure.
  3. Analyze tiger tables to avoid orca notices.
  4. Ignore orca related notice and hints in test outputs.
  5. Add analyze for lookup tables.
  6. Fix rt_mapalgebra test output ordering.
  7. Add libtiff dep check for gppkg.
  8. Romove libtiff dep check for gppkg.
  9. Fix tiger geocoder.
  10. Fix tiger and raster tests.
  11. Change XML parsing to use default (SAX2) parser.
  12. Rephrase README.md and postgis package docs version and description.

Describe your change clearly, including what problem is being solved or what document is being added or updated.

  • Added upstream source of postgis 3.3.2
  • Updated gdal and proj
  • Fix failed test: ./regress/core/tickets .. failed (diff expected obtained: /tmp/pgis_reg/test_82_diff)
  • Fix: added depedency check in .spec file as part of preinstall script
  • Adds a plpython function to generate the state-wise scripts for tiger geocoder
    etc.

Why are the changes needed?

  • PostGIS 2.5.9 is the end-of-life release of the 2.5 branch.

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the cloudberrydb team to help review and approve.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 4 committers have signed the CLA.

✅ August-beaulo
❌ shrakesh
❌ orhankislal
❌ Sanath97
You have signed the CLA already but the status is still pending? Let us recheck it.

orhankislal and others added 13 commits June 13, 2024 13:59
updated the postgis from 2.5.4 to 3.3.2, the new updated postgis will be supported from 7X. As part of that following are the changes made in this pr:

- Added upstream source of postgis 3.3.2
- Updated gdal and proj
- Updated readme, lib readme
- done clean up of 2.5 or older version-related stuff,
  as the main branch will be having source related to postgis 3.3
- Updated version info

Co-authored-by: Orhan Kislal <[email protected]>
Failed test:  ./regress/core/tickets .. failed (diff expected obtained: /tmp/pgis_reg/test_82_diff)
with following reason
NOTICE:  One or more columns in the following table(s) do not have statistics: utm_dots
Fix: as the notice was because analyze <tablename> was not performed for
the test and minimum log level was set to notice causing this diff.
Added analyze utm_dots; instruction to the test query.
Issue:
if the ibtiff is not available still the postgis gppkg is getting
installed.  this causing the issue while creating a postgis extension
for database.

Fix: added depedency check in .spec file as part of preinstall script.

In gppkg there is plan to add dependency check as part of host
requirement, but that yet to implement. so for now adding check in spec
file to error out if libtiff is not available.
This commit adds a plpython function to generate the state-wise scripts
for tiger geocoder.
Tiger installer creates plpython which was necessary for the tests but
it actually breaks the installation if the db already has the language.
Instead we add the language loading work to the pg_regress.

We also disable orca for one the raster tests since it was giving
sporadic errors.
This commit updates the README  and postgis package docs version and
description:

This commit includes the following changes:
1. README.md:
   - Replaced all instances of "Greenplum" with "Cloudberry" to reflect
     the new naming convention.
2. postgis/package/gppkg_spec.yml.in:
   - update the version of hashdata and cloudberry database and the
     description of postgis.
3. postgis/package/gppkg_spec_v2.yml.in:
   - update the version of hashdata and cloudberry database and the
     description of postgis.
4. postgis/package/postgis.spec:
  - update the summary and description of postgis.

 Related to Issue#id <cloudberry-contrib#2>
@tuhaihe
Copy link
Member

tuhaihe commented Sep 2, 2024

Hey @August-beaulo, hope you're doing well! I'm just curious about the progress of this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Upgrade PostGIS version 2.5.4 to newer
6 participants