Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D1] Cleaning up Build with D1 #18321

Open
wants to merge 14 commits into
base: production
Choose a base branch
from
Open

[D1] Cleaning up Build with D1 #18321

wants to merge 14 commits into from
+496 −889

Conversation

Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Nov 21, 2024 •
edited
Loading

Summary

  1. Moved "Error" and "Error list" section out of "Query D1", and into Observability/Debug D1/.
  2. Added a public/redirect for "Query D1" into "Workers Binding API".
  3. Replaced all links pointing to Query D1 to the new API chapters, being as specific as possible.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions github-actions bot added the product:d1 D1: https://developers.cloudflare.com/d1/ label Nov 21, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2024 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8b38884
Status: ✅  Deploy successful!
Preview URL: https://ee6d5903.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/d1/build-with-d1/d1-client-api/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/build-with-d1/d1-client-api/
https://developers.cloudflare.com/workers/wrangler/commands/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/workers/wrangler/commands/
https://developers.cloudflare.com/d1/observability/debug-d1/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/observability/debug-d1/
https://developers.cloudflare.com/d1/build-with-d1/query-d1/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/build-with-d1/query-d1/
https://developers.cloudflare.com/d1/worker-api/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/worker-api/
https://developers.cloudflare.com/d1/rest-api/wrangler-commands/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/rest-api/wrangler-commands/
https://developers.cloudflare.com/d1/rest-api/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/rest-api/
https://developers.cloudflare.com/d1/tutorials/build-an-api-to-access-d1/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/tutorials/build-an-api-to-access-d1/
https://developers.cloudflare.com/d1/get-started/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/get-started/
https://developers.cloudflare.com/d1/reference/wrangler-commands/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/reference/wrangler-commands/
https://developers.cloudflare.com/d1/build-with-d1/foreign-keys/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/build-with-d1/foreign-keys/
https://developers.cloudflare.com/d1/build-with-d1/query-json/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/build-with-d1/query-json/
https://developers.cloudflare.com/d1/worker-api/prepared-statements/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/worker-api/prepared-statements/
https://developers.cloudflare.com/d1/build-with-d1/import-export-data/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/build-with-d1/import-export-data/
https://developers.cloudflare.com/d1/ https://jun-d1-api-cleanup.cloudflare-docs-7ou.pages.dev/d1/

@github-actions github-actions bot added size/m product:pages product:workers Related to Workers product and removed size/s labels Nov 21, 2024
hyperlint-ai[bot]
hyperlint-ai bot reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 files reviewed, 3 total issue(s) found.

src/content/docs/d1/worker-api/prepared-statements.mdx Show resolved Hide resolved
src/content/docs/d1/worker-api/prepared-statements.mdx Show resolved Hide resolved
src/content/docs/d1/worker-api/prepared-statements.mdx Show resolved Hide resolved
@github-actions github-actions bot added size/xl and removed size/m labels Nov 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /d1/build-with-d1/d1-client-api/
  • /d1/reference/wrangler-commands/
  • /d1/d1-api/

daisyfaithauma
daisyfaithauma requested changes Nov 22, 2024
View reviewed changes
public/_redirects Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

@daisyfaithauma daisyfaithauma daisyfaithauma requested changes

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@rozenmd rozenmd Awaiting requested review from rozenmd rozenmd is a code owner

@vy-ton vy-ton Awaiting requested review from vy-ton vy-ton is a code owner

@joshthoward joshthoward Awaiting requested review from joshthoward joshthoward is a code owner

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@KianNH KianNH Awaiting requested review from KianNH KianNH is a code owner

@pedrosousa pedrosousa Awaiting requested review from pedrosousa pedrosousa is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@tanushree-sharma tanushree-sharma Awaiting requested review from tanushree-sharma tanushree-sharma is a code owner

@ToriLindsay ToriLindsay Awaiting requested review from ToriLindsay ToriLindsay is a code owner

@penalosa penalosa Awaiting requested review from penalosa penalosa is a code owner

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin petebacondarwin is a code owner

@dario-piotrowicz dario-piotrowicz Awaiting requested review from dario-piotrowicz dario-piotrowicz is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@aninibread aninibread Awaiting requested review from aninibread aninibread is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@elithrar elithrar

@pedrosousa pedrosousa

@rozenmd rozenmd

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@joshthoward joshthoward

@vy-ton vy-ton

@KianNH KianNH

@Oxyjun Oxyjun

Labels
product:d1 D1: https://developers.cloudflare.com/d1/ product:pages product:workers Related to Workers product size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Oxyjun @daisyfaithauma @elithrar @pedrosousa @rozenmd @GregBrimble @WalshyDev @joshthoward @vy-ton @KianNH