-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thomasgauvin: add new database examples to hyperdrive #18342
Open
thomasgauvin
wants to merge
1
commit into
production
Choose a base branch
from
thomasgauvin-add-new-database-types
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasgauvin
requested review from
elithrar,
sejoker,
Oxyjun and
a team
as code owners
November 21, 2024 23:43
github-actions
bot
added
product:hyperdrive
Hyperdrive: https://developers.cloudflare.com/hyperdrive/
size/s
labels
Nov 21, 2024
Deploying cloudflare-docs with Cloudflare Pages
|
Oxyjun
approved these changes
Nov 22, 2024
Comment on lines
+17
to
18
You can connect Hyperdrive to any existing pgEdge database with the default user and password | ||
provided by pgEdge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
You can connect Hyperdrive to any existing pgEdge database with the default user and password | |
provided by pgEdge. | |
You can connect Hyperdrive to any existing pgEdge database with the default user and password provided by pgEdge. |
Comment on lines
+27
to
+30
1. In the [Azure Portal](https://portal.azure.com/), select the instance you want Hyperdrive to connect to. | ||
2. Expand **Settings** > **Networking** > ensure **Public access** is enabled > in **Firewall rules** add `0.0.0.0` as **Start IP address** and `255.255.255.255` as **End IP address**. | ||
3. Select **Save** to persist your changes. | ||
4. Select **Overview** from the sidebar and note down the **Server name** of your instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
1. In the [Azure Portal](https://portal.azure.com/), select the instance you want Hyperdrive to connect to. | |
2. Expand **Settings** > **Networking** > ensure **Public access** is enabled > in **Firewall rules** add `0.0.0.0` as **Start IP address** and `255.255.255.255` as **End IP address**. | |
3. Select **Save** to persist your changes. | |
4. Select **Overview** from the sidebar and note down the **Server name** of your instance. | |
1. In the [Azure Portal](https://portal.azure.com/), select the instance you want Hyperdrive to connect to. | |
2. Expand **Settings** > **Networking**. | |
3. Go to **Firewall rules** and ensure 'Public access' is enabled. | |
4. Add `0.0.0.0` as 'Start IP address' and `255.255.255.255` as 'End IP address'. | |
5. Select **Save** to persist your changes. | |
6. Select **Overview** from the sidebar and note down the **Server name** of your instance. |
3. Select **Save** to persist your changes. | ||
4. Select **Overview** from the sidebar and note down the **Server name** of your instance. | ||
|
||
With the username, password, server name and database name (default: `postgres`), you can now create a Hyperdrive database configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
With the username, password, server name and database name (default: `postgres`), you can now create a Hyperdrive database configuration. | |
With the username, password, server name, and database name (default: `postgres`), you can now create a Hyperdrive database configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.