GFI-151: add ecs_support to teams_location #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
teams_locations.go
Outdated
| @@ -35,6 +35,7 @@ type TeamsLocation struct { | |||
| AnonymizedLogsEnabled bool `json:"anonymized_logs_enabled"` | |||
| IPv4Destination string `json:"ipv4_destination"` | |||
| ClientDefault bool `json:"client_default"` | |||
| ECSSupport bool `json:"ecs_support,omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| ECSSupport bool `json:"ecs_support,omitempty"` | |
| ECSSupport *bool `json:"ecs_support,omitempty"` |
https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans
|
This functionality has been released in v0.94.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ecs_support field for locations has been present in the API but missing in terraform. This adds it.
https://developers.cloudflare.com/api/operations/zero-trust-gateway-locations-create-zero-trust-gateway-location
Has your change been tested?
Unit tests
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.