Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add into_inner() for HTTP client and server #412

Closed
wants to merge 1 commit into from
Closed

Add into_inner() for HTTP client and server #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pingora-core/src/protocols/http/v1/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,13 @@ impl HttpSession {
pub fn stream(&self) -> &Stream {
&self.underlying_stream
}

/// Consume `self`, the underlying [Stream] will be returned and can be used
/// directly, for example, in the case of HTTP upgrade. It is not flushed
/// prior to being returned.
pub fn into_inner(self) -> Stream {
self.underlying_stream
}
}

#[inline]
Expand Down
7 changes: 7 additions & 0 deletions pingora-core/src/protocols/http/v1/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,13 @@ impl HttpSession {
pub fn stream(&self) -> &Stream {
&self.underlying_stream
}

/// Consume `self`, the underlying stream will be returned and can be used
/// directly, for example, in the case of HTTP upgrade. The stream is not
/// flushed prior to being returned.
pub fn into_inner(self) -> Stream {
self.underlying_stream
}
}

// Regex to parse request line that has illegal chars in it
Expand Down