Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pingora-core: Update socket dependency #413

Closed
wants to merge 1 commit into from
Closed

pingora-core: Update socket dependency #413

wants to merge 1 commit into from

Conversation

sargun
Copy link
Contributor

@sargun sargun commented Oct 8, 2024

We have the socket version at 0, which matches 0.3 as well. That wont work because it doesn't have feature "all". We need 0.4+.

=0.4, <1, should match ^0, but exclude 0.3.

@sargun
pingora-core: Update socket dependency
98debd9 
We have the socket version at 0, which matches 0.3 as well. That
wont work because it doesn't have feature "all". We need 0.4+.
>=0.4, <1, should match ^0, but exclude 0.3.
@eaufavor eaufavor added the dependencies Pull requests that update a dependency file label Oct 9, 2024
@drcaramelsyrup drcaramelsyrup self-assigned this Oct 11, 2024
@sargun
Copy link
Contributor Author

sargun commented Oct 17, 2024

👋

drcaramelsyrup
drcaramelsyrup approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@drcaramelsyrup drcaramelsyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, because 0.3 doesn't actually contain the needed feature.
Thanks for catching this, I'll start getting this pushed for our internal sync.

@drcaramelsyrup drcaramelsyrup added the Accepted This change is accepted by us and merged to our internal repo label Oct 18, 2024
johnhurt pushed a commit that referenced this pull request Oct 28, 2024
@sargun @drcaramelsyrup
pingora-core: Update socket dependency
c2718e0 
We have the socket version at 0, which matches 0.3 as well. That
wont work because it doesn't have feature "all". We need 0.4+.
>=0.4, <1, should match ^0, but exclude 0.3.

Includes-commit: 98debd9
Replicated-from: #413
johnhurt pushed a commit that referenced this pull request Oct 28, 2024
@sargun @johnhurt
pingora-core: Update socket dependency
dd99314 
We have the socket version at 0, which matches 0.3 as well. That
wont work because it doesn't have feature "all". We need 0.4+.
>=0.4, <1, should match ^0, but exclude 0.3.

Includes-commit: 98debd9
Replicated-from: #413
@johnhurt
Copy link
Contributor

This has been merged as part of the weekly sync. Thank you for your contributions! 🎉

@johnhurt johnhurt closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drcaramelsyrup drcaramelsyrup drcaramelsyrup approved these changes

Assignees

@drcaramelsyrup drcaramelsyrup

Labels
Accepted This change is accepted by us and merged to our internal repo dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sargun @johnhurt @drcaramelsyrup @eaufavor