Fixed RUSTLS on Windows Compilation #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredr
reviewed
Nov 8, 2024
| @@ -216,9 +216,15 @@ impl<T> UniqueID for TlsStream<T> | |||
| where | |||
| T: UniqueID, | |||
| { | |||
| #[cfg(not(target_os = "windows"))] | |||
There was a problem hiding this comment.
Suggested change
| #[cfg(not(target_os = "windows"))] | |
| #[cfg(unix)] |
To keep it consistent with the other cfg statements
| fn id(&self) -> i32 { | ||
| self.tls.stream.as_ref().unwrap().get_ref().0.id() | ||
| } | ||
|
|
||
| #[cfg(target_os = "windows")] |
There was a problem hiding this comment.
Suggested change
| #[cfg(target_os = "windows")] | |
| #[cfg(windows)] |
|
Addressed with #471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated my project to windows and had issues compiling the underlying pingora lib's modifed the compilation of the impl UniqueID for TlsStream and it allowewd me to compile. I am still familiarizing myself with the code base so I am unsure if this is the best way to do this but it worked for me.