Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-11-08 weekly sync #458

Merged
merged 6 commits into from
Nov 8, 2024
Merged

2024-11-08 weekly sync #458

merged 6 commits into from
Nov 8, 2024

Commits on Nov 1, 2024

  1. Check h2 stream end for error

    Certain APIs consuming HTTPTasks want to know if the response has
    finished. However, in cases such as protocol errors the h2 RecvStream
    will return `is_end_stream` which may be associated with an HTTPTask
    that was not actually the end of stream. This affects systems such as
    caching which wants to know when the response has properly finished for
    finishing a cache miss.
    
    This change attempts to check if the stream has ended due to an h2 error
    or not to forward a successful or Failed HTTPTask as appropriate.
    drcaramelsyrup committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4e4eb5a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Remove unused matches=0.1 dependency crate

    The rust 2021 use rust version is 1.56.0, `matches` included in the
    standard library prelude and thus is automatically in scope.
    
    Includes-commit: ebc6cbf
    Replicated-from: #414
    Signed-off-by: Xiaobo Liu <[email protected]>
    cppcoffee authored and gdavidsson committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    4ea8032 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. add builder api for pingora listeners:

    This change takes the existing API for ListenerEndpoint and modifies it to use a typical idiomatic builder style.
    
    There are additional improvements which I feel can be made here, but I believe that it would be better to do them in subsequent commits in order to keep changes as incremental as possible.
    
    In particular, I think that making socket options into sub-builder is probably a good move.
    Noah-Kennedy committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ee42db5 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    e89f198 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Fix cache meta trace tags

    Currently the meta is attempted to be logged in a hit span that may or
    may not exist (or has not started) depending on the cache phase.
    drcaramelsyrup committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    2d110d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    66b5930 View commit details
    Browse the repository at this point in the history