2024-11-22 weekly sync #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The h2 crate does not appear to check for content-length underflow if only a header frame is received with END_STREAM.
After a request is predicted uncacheable and bypasses cache, it may still be cached if the response is a 200. However, HEAD responses are not normally cacheable as they don't include the actual response body.
The PUT request body itself may be chunked, but normally clients send the body that ought to be cached without chunked encoding applied.
Includes-commit: d26d344 Replicated-from: #471 Co-authored-by: Matthew Gumport <[email protected]>
The cache locks may be held after serving stale, proxy upstream filter, or revalidate uncacheable resulting in dangling cache locks. Also only disable cache on final error if cache was not already disabled, and add DeclinedToUpstream / UpstreamError no cache reasons.
gumpt
force-pushed
the
bleeper-mgumport-89319e9383d6f99066dfeace750a553d45e1c167
branch
from
9fafee8
to
725329f
Compare
drcaramelsyrup
approved these changes
Nov 22, 2024
andrewhavck
approved these changes
Nov 22, 2024
johnhurt
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.