Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic of promql/series #1279

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Improve logic of promql/series #1279

merged 3 commits into from
Feb 11, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.70.0-59-gbd87614
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Feb 11, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.94m ± 1%   39.86m ± 9%       ~ (p=0.853 n=10)
CheckRules-4     8.513 ± 2%    8.466 ± 2%       ~ (p=0.123 n=10)
geomean         583.1m        581.0m       -0.38%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.075 n=10)
CheckRules-4    977.4Mi ± 0%   973.7Mi ± 0%  -0.39% (p=0.000 n=10)
geomean         163.7Mi        163.3Mi       -0.20%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.133 n=10)
CheckRules-4    14.11M ± 0%   14.03M ± 0%  -0.56% (p=0.000 n=10)
geomean         1.363M        1.360M       -0.28%

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (f02d8df) to head (bd87614).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   95.21%   95.20%   -0.02%     
==========================================
  Files         105      105              
  Lines       12813    12839      +26     
==========================================
+ Hits        12200    12223      +23     
- Misses        466      468       +2     
- Partials      147      148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 313e8a2 into main Feb 11, 2025
20 checks passed
@prymitive prymitive deleted the series branch February 11, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants