Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aggregation logic from promql/fragile #1299

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

prymitive
Copy link
Collaborator

Fixes #1289.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.70.0-99-ga60fc7c
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Feb 20, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   34.90m ± 1%   35.01m ± 2%       ~ (p=0.123 n=10)
CheckRules-4     8.458 ± 2%    8.489 ± 2%       ~ (p=0.280 n=10)
geomean         543.4m        545.2m       +0.33%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=1.000 n=10)
CheckRules-4    984.9Mi ± 0%   982.8Mi ± 0%  -0.22% (p=0.001 n=10)
geomean         164.3Mi        164.1Mi       -0.11%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.981 n=10)
CheckRules-4    14.34M ± 0%   14.32M ± 0%  -0.10% (p=0.000 n=10)
geomean         1.374M        1.374M       -0.05%

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (e045a3e) to head (a60fc7c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   95.29%   95.27%   -0.02%     
==========================================
  Files         106      106              
  Lines       13087    13044      -43     
==========================================
- Hits        12471    12428      -43     
  Misses        468      468              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 3d27620 into main Feb 20, 2025
20 checks passed
@prymitive prymitive deleted the promql/fragile branch February 20, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: promql/fragile should not warn when using without and joining with explicit labelset
2 participants