Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we always set ParseErr line number #1305

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Make sure we always set ParseErr line number #1305

merged 1 commit into from
Feb 21, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.70.0-105-g3ec2cfc
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   34.96m ± 1%   34.95m ± 4%       ~ (p=0.853 n=10)
CheckRules-4     8.486 ± 2%    8.468 ± 2%       ~ (p=0.796 n=10)
geomean         544.7m        544.1m       -0.11%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.971 n=10)
CheckRules-4    985.5Mi ± 0%   984.7Mi ± 0%       ~ (p=0.436 n=10)
geomean         164.3Mi        164.3Mi       -0.04%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.537 n=10)
CheckRules-4    14.34M ± 0%   14.33M ± 0%       ~ (p=0.481 n=10)
geomean         1.374M        1.374M       -0.02%

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (9bd8190) to head (3ec2cfc).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/parser/parser.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1305   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files         106      106           
  Lines       13044    13044           
=======================================
  Hits        12428    12428           
  Misses        468      468           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 26d44b9 into main Feb 21, 2025
20 checks passed
@prymitive prymitive deleted the recover branch February 21, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants