Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate validation on labels and annotations #834

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.53.0-97-ga138844
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Dec 19, 2023

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   108.7m ± 1%   108.9m ± 1%       ~ (p=0.353 n=10)
CheckRules-4    107.1m ± 1%   102.0m ± 1%  -4.78% (p=0.000 n=10)
geomean         107.9m        105.4m       -2.31%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   69.36Mi ± 0%   69.35Mi ± 0%       ~ (p=0.075 n=10)
CheckRules-4    127.0Mi ± 0%   119.5Mi ± 0%  -5.88% (p=0.000 n=10)
geomean         93.86Mi        91.05Mi       -2.99%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   540.1k ± 0%   540.1k ± 0%  -0.00% (p=0.021 n=10)
CheckRules-4    956.2k ± 0%   901.9k ± 0%  -5.68% (p=0.000 n=10)
geomean         718.6k        697.9k       -2.88%

@prymitive prymitive force-pushed the labels branch 4 times, most recently from 961fb8e to 826af64 Compare February 21, 2024 13:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.14286% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 94.27%. Comparing base (d9e7b3b) to head (a138844).

Files Patch % Lines
internal/parser/parser.go 87.14% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   94.60%   94.27%   -0.34%     
==========================================
  Files          92       92              
  Lines       10036    10095      +59     
==========================================
+ Hits         9495     9517      +22     
- Misses        402      435      +33     
- Partials      139      143       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 6bb10cd into main Feb 23, 2024
20 checks passed
@prymitive prymitive deleted the labels branch February 23, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants