Fix incorrect example for disabling promql/aggregate #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the definition on how to disable the promql/aggregate rule for `strip` labels, it is stated to use :false as the suffix, but then uses :true in the example with a specific label. Update the second example to match the first, correct, one.
|
Looks like gh actions assumes a PR is not from a fork: https://github.com/cloudflare/pint/actions/runs/7713027644/workflow#L25 - though I'm not sure what the checkout main branch step is trying to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the definition on how to disable the promql/aggregate rule for
striplabels, it is stated to use :false as the suffix, but then uses :true in the example with a specific label.Update the second example to match the first, correct, one.