Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiple documents #894

Closed
wants to merge 0 commits into from
Closed

Conversation

felipesere
Copy link
Contributor

@felipesere felipesere commented Mar 5, 2024

This now has 2 tests as I created a new one before I spotted the one at the bottom.

I tested this locally and it happily works through my large Kubernetes manifests finding the correct rule violations.

fixes #746

@felipesere felipesere requested a review from prymitive as a code owner March 5, 2024 16:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.72%. Comparing base (a27ad9b) to head (93ef074).

Files Patch % Lines
internal/parser/parser.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   94.75%   94.72%   -0.03%     
==========================================
  Files          92       92              
  Lines        8729     8740      +11     
==========================================
+ Hits         8271     8279       +8     
- Misses        315      317       +2     
- Partials      143      144       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PrometheusRule contained in larger YAML manifest
3 participants