Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Clean up Bazel tags, fix excessive Windows warnings #3100

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Nov 12, 2024

  • Disable Dawn diagnostic leading to excessive warning volume on Windows
  • Drop check for libc++ >= 15, we have required LLVM 15 for a while.
  • Don't mark workerd binary as no-arm64, which caused problems for downstream
    where it still needs to be built.
  • Drop superfluous CI filter overrides – we already set the filters to
    off-by-default in the global config.
  • Drop "slow" bazel tag – this has been superseded by the "enormous" size filter.

@fhanau fhanau force-pushed the felix/111224-v8-multiple-cage branch 2 times, most recently from 3078a03 to 5934923 Compare November 14, 2024 17:40
@fhanau fhanau changed the title [EXP] Explore V8 configuration settings [build] Clean up Bazel tags, fix excessive Windows warnings Nov 14, 2024
@fhanau fhanau marked this pull request as ready for review November 14, 2024 18:29
@fhanau fhanau requested review from a team as code owners November 14, 2024 18:29
@fhanau fhanau force-pushed the felix/111224-v8-multiple-cage branch from 5934923 to acab33a Compare November 22, 2024 21:11
- Disable Dawn diagnostic leading to excessive warning volume on Windows
- Drop check for libc++ >= 15, we have required LLVM 15 for a while.
- Don't mark workerd binary as no-arm64, which caused problems for downstream
  where it still needs to be built.
- Drop superfluous CI filter overrides – we already set the filters to
  off-by-default in the global config.
- Drop "slow" bazel tag – this has been superseded by the "enormous" size filter.
@fhanau fhanau force-pushed the felix/111224-v8-multiple-cage branch from acab33a to c51874a Compare November 22, 2024 21:49
@fhanau fhanau merged commit a23e95c into main Nov 22, 2024
14 checks passed
@fhanau fhanau deleted the felix/111224-v8-multiple-cage branch November 22, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants