Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] improve formatting of cache options in hyperdrive list command #8583

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

knickish
Copy link
Contributor

@knickish knickish commented Mar 19, 2025

Fixes n/a

formatting was not great for the wrangler hyperdrive list command, this PR just adjusts the formatting of the cache display to reduce the number of configs for which the display table formatting will be unaligned


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no functionality changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ui-formatting change only
  • Wrangler V3 Backport

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 0e8703e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@knickish knickish marked this pull request as ready for review March 19, 2025 19:41
@knickish knickish requested a review from a team as a code owner March 19, 2025 19:41
@ReppCodes
Copy link

Looks like a nice readability improvement to me, approved by Hyperdrive team.

Copy link
Contributor

github-actions bot commented Mar 20, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-wrangler-8583

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8583/npm-package-wrangler-8583

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-wrangler-8583 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-workers-bindings-extension-8583 -O ./cloudflare-workers-bindings-extension.0.0.0-vc1c2d9315.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc1c2d9315.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-create-cloudflare-8583 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-kv-asset-handler-8583

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-miniflare-8583

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-pages-shared-8583

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-unenv-preset-8583

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-vite-plugin-8583

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-vitest-pool-workers-8583

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-workers-editor-shared-8583

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-workers-shared-8583

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14110035327/npm-package-cloudflare-workflows-shared-8583

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.5.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.0
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit ecbab5d into cloudflare:main Mar 28, 2025
16 of 30 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Mar 28, 2025
Copy link

holopin-bot bot commented Mar 28, 2025

Congratulations @knickish, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm8sgo05846670cjxxculnchj

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants