-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] add validation to redirected configs in regards to environments #8596
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8cbe58d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f51b420
to
06b83c9
Compare
06b83c9
to
31466bf
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-wrangler-8596 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8596/npm-package-wrangler-8596 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-wrangler-8596 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-workers-bindings-extension-8596 -O ./cloudflare-workers-bindings-extension.0.0.0-v9b064942a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v9b064942a.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-create-cloudflare-8596 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-kv-asset-handler-8596 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-miniflare-8596 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-pages-shared-8596 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-unenv-preset-8596 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-vite-plugin-8596 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-vitest-pool-workers-8596 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-workers-editor-shared-8596 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-workers-shared-8596 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14058778816/npm-package-cloudflare-workflows-shared-8596 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Pages doesn't really support environments and even shows errors when they are used:
So I don't think that adding tests for this for the pages commands is necessary here 🤔 |
0c2b095
to
4a1748a
Compare
8caffe9
to
cca92dc
Compare
cca92dc
to
8cbe58d
Compare
Fixes #8359
This PR adds the following validation behaviors to wrangler deploy commands, that relate
to redirected configs (i.e. config files specified by
.wrangler/deploy/config.json
files):environment (i.e. a build tool should generate redirected configs already targeting specific
environments), so if wrangler encounters a redirected config with some environments defined
it should error
--env=my-env
) when using redirectedconfigs is incorrect, so these environments should be ignored and a warning should be
presented to the user