Skip to content

Commit

Permalink
feat(cost-analysis): improve translation text for unified-cost page
Browse files Browse the repository at this point in the history
- Introduced a new translation key for admin-specific cost descriptions.
- Updated the component to display different messages based on admin mode.
- Enhanced language packs with translations for the new description.

Signed-off-by: sulmo <[email protected]>
  • Loading branch information
sulmoJ committed Dec 23, 2024
1 parent 973057a commit ee55ab7
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ watch(() => state.favoriteOptions, async (favoriteOptions) => {
icon="ic_info-circle"
layout="in-section"
>
{{ $t('COST_EXPLORER.COST_ANALYSIS.UNIFIED_COST_DESC') }}
{{ storeState.isAdminMode ? $t('COST_EXPLORER.COST_ANALYSIS.UNIFIED_COST_ADMIN_DESC') : $t('COST_EXPLORER.COST_ANALYSIS.UNIFIED_COST_DESC') }}
</p-scoped-notification>
<p-divider class="heading-divider" />
<cost-analysis-query-form-modal :visible.sync="state.queryFormModalVisible"
Expand Down
21 changes: 21 additions & 0 deletions packages/language-pack/console-translation-2.8.babel
Original file line number Diff line number Diff line change
Expand Up @@ -27324,6 +27324,27 @@
<folder_node>
<name>COST_ANALYSIS</name>
<children>
<concept_node>
<name>UNIFIED_COST_ADMIN_DESC</name>
<definition_loaded>false</definition_loaded>
<description/>
<comment/>
<default_text/>
<translations>
<translation>
<language>en-US</language>
<approved>false</approved>
</translation>
<translation>
<language>ja-JP</language>
<approved>false</approved>
</translation>
<translation>
<language>ko-KR</language>
<approved>false</approved>
</translation>
</translations>
</concept_node>
<concept_node>
<name>UNIFIED_COST_DESC</name>
<definition_loaded>false</definition_loaded>
Expand Down
5 changes: 3 additions & 2 deletions packages/language-pack/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -1546,14 +1546,15 @@
"ANOMALY_DETECTION_CONFIGURATION": "Anomaly Detection Configuration",
"COST_ADVANCED_SETTINGS": "Advanced Settings",
"COST_ANALYSIS": {
"UNIFIED_COST_DESC": "Unified Cost enables consolidated cost management across multiple data sources."
"UNIFIED_COST_ADMIN_DESC": "Unified Cost enables consolidated cost management across multiple data sources. The currency for Unified Cost can be configured on the [Advanced Settings] > [Currency Converter] page.",
"UNIFIED_COST_DESC": "Unified Cost enables consolidated cost management across multiple data sources. The currency for each Unified Cost is reflected as configured by admin."
},
"CURRENCY_CONVERTER": "Currency Converter",
"CURRENCY_CONVERTER_PAGE": {
"AGGREGATION_DATE": "Aggregation Date",
"EXCHANGE_RATE_SOURCE": "Exchange Rate Source",
"LAST_DAY_OF_THE_MONTH": "Last day of the month",
"NOTIFICATION": "Once aggregated, date changes will take effect starting next month.",
"NOTIFICATION": "The currency for Unified Cost can be set on the Cost Analysis page. Once aggregated, date changes will take effect starting next month.",
"UPDATE_SUCCESS_ALT": "Currency Settings successfully updated"
}
},
Expand Down
5 changes: 3 additions & 2 deletions packages/language-pack/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -1546,14 +1546,15 @@
"ANOMALY_DETECTION_CONFIGURATION": "異常コスト検知設定",
"COST_ADVANCED_SETTINGS": "詳細設定",
"COST_ANALYSIS": {
"UNIFIED_COST_DESC": "複数のデータソースのコストを一元管理できるようにサポートします。"
"UNIFIED_COST_ADMIN_DESC": "複数のデータソースのコストを一元管理できるようにサポートします。Unified Costの通貨は、[詳細設定] > [為替レート設定] ページで設定できます。",
"UNIFIED_COST_DESC": "複数のデータソースのコストを一元管理できるようにサポートします。Unified Costの通貨は、管理者が設定した基準に従って反映されます。"
},
"CURRENCY_CONVERTER": "為替レート設定",
"CURRENCY_CONVERTER_PAGE": {
"AGGREGATION_DATE": "集計日",
"EXCHANGE_RATE_SOURCE": "為替基準",
"LAST_DAY_OF_THE_MONTH": "月末",
"NOTIFICATION": "集計が完了すると、日付の変更は翌月から適用されます。",
"NOTIFICATION": "データソースページで、Unified Costの為替レートを設定できます。費用集計が完了すると、日付の変更は翌月から適用されます。",
"UPDATE_SUCCESS_ALT": "通貨設定が正常に更新されました"
}
},
Expand Down
5 changes: 3 additions & 2 deletions packages/language-pack/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -1546,14 +1546,15 @@
"ANOMALY_DETECTION_CONFIGURATION": "이상 비용 탐지 설정",
"COST_ADVANCED_SETTINGS": "고급 설정",
"COST_ANALYSIS": {
"UNIFIED_COST_DESC": "모든 데이터 소스의 비용을 한 곳에서 통합하여 관리할 수 있도록 지원합니다."
"UNIFIED_COST_ADMIN_DESC": "모든 데이터 소스의 비용을 한 곳에서 통합하여 관리할 수 있도록 지원합니다. Unified Cost의 통화는 [고급 설정] > [환율 설정] 페이지에서 설정 가능합니다.",
"UNIFIED_COST_DESC": "모든 데이터 소스의 비용을 한 곳에서 통합하여 관리할 수 있도록 지원합니다. Unified Cost의 통화는 관리자가 설정한 기준에 따라 반영됩니다."
},
"CURRENCY_CONVERTER": "환율 설정",
"CURRENCY_CONVERTER_PAGE": {
"AGGREGATION_DATE": "집계 날짜",
"EXCHANGE_RATE_SOURCE": "환율 기준",
"LAST_DAY_OF_THE_MONTH": "매월 마지막일 ",
"NOTIFICATION": "집계가 완료되면, 날짜 변경은 다음 달부터 적용됩니다.",
"NOTIFICATION": "비용 분석 페이지에서 Unified Cost에 대한 환율을 설정할 수 있습니다. 비용 집계가 완료되면, 날짜 변경은 다음 달부터 적용됩니다.",
"UPDATE_SUCCESS_ALT": "환율 설정 업데이트 완료"
}
},
Expand Down

0 comments on commit ee55ab7

Please sign in to comment.