Skip to content

Commit

Permalink
fix(dashboard): solve dashboard QAs (#5558)
Browse files Browse the repository at this point in the history
* fix(group-by-field): solve selected-group-by sorting issue

Signed-off-by: samuel.park <[email protected]>

* chore: small fix

Signed-off-by: samuel.park <[email protected]>

* fix(value-mapping): temporarily remove expand button

Signed-off-by: samuel.park <[email protected]>

---------

Signed-off-by: samuel.park <[email protected]>
  • Loading branch information
piggggggggy authored Jan 20, 2025
1 parent a67fa25 commit fcf763a
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ const handleClickAddCase = () => {
const handleClickDeleteCase = (idx: number) => {
casesInfo.value.splice(idx, 1);
};
const handleClickExpand = (idx: number) => {
state.expandCaseMap[idx] = !state.expandCaseMap[idx];
state.expandCaseMap = { ...state.expandCaseMap };
};
// const handleClickExpand = (idx: number) => {
// state.expandCaseMap[idx] = !state.expandCaseMap[idx];
// state.expandCaseMap = { ...state.expandCaseMap };
// };
const handleUpdateBasedOn = (key: string) => {
keyInfo.value = key;
};
Expand Down Expand Up @@ -247,11 +247,11 @@ watch(() => state.invalid, (_invalid) => {
:disabled="casesInfo.length === 1"
@click="handleClickDeleteCase(cIdx)"
/>
<p-icon-button name="ic_arrows-expand-all"
size="sm"
class="expand-button"
@click="handleClickExpand(cIdx)"
/>
<!-- <p-icon-button name="ic_arrows-expand-all"-->
<!-- size="sm"-->
<!-- class="expand-button"-->
<!-- @click="handleClickExpand(cIdx)"-->
<!-- />-->
</div>
<div class="grid grid-cols-12 gap-2">
Expand Down Expand Up @@ -319,7 +319,6 @@ watch(() => state.invalid, (_invalid) => {
@apply bg-white rounded border border-gray-150;
position: relative;
padding: 0.5rem;
z-index: 1;
margin-bottom: 0.5rem;
&.expanded {
width: 35rem;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ const state = reactive({
}
if (state.fixedValue) return state.fixedValue;
if (state.multiselectable) {
return state.menuItems.filter((d) => state.fieldValue.data?.includes(d.name));
return state.fieldValue.data?.map((d) => {
const validMenuItem = state.menuItems.find((item) => item.name === d);
return validMenuItem || { name: d, label: d };
}) || [];
}
return state.fieldValue.data;
}),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const sankeyChart: WidgetConfig = {
widgetName: 'sankeyChart',
meta: {
title: 'Sankey Chart',
sizes: ['md'],
sizes: ['md', 'full'],
defaultValidationConfig: {
defaultMaxCount: 1,
},
Expand Down

0 comments on commit fcf763a

Please sign in to comment.