Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set query filter only if there're value & fix qa things #3717

Merged
merged 7 commits into from
May 9, 2024

Conversation

yuda110
Copy link
Member

@yuda110 yuda110 commented May 8, 2024

To Reviewers

  • Skip (style, chore, ci, minor refactoring, etc.)
  • Need discussion
  • Not that difficult
  • Approved feature branch merge to master

Description

commits!

Things to Talk About

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:01pm
feature-feedback ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:01pm
feature-metric-explorer ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:01pm
feature-project-workspace-home ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:01pm

Copy link
Member

@piggggggggy piggggggggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Member

@sulmoJ sulmoJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuda110 yuda110 merged commit 57560d4 into cloudforet-io:feature-feedback May 9, 2024
7 checks passed
@yuda110 yuda110 deleted the feature/qaqa branch May 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants