Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rebase onto master #5027

Closed
wants to merge 13 commits into from
Closed

chore: rebase onto master #5027

wants to merge 13 commits into from

Conversation

WANZARGEN
Copy link
Member

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

admin-cloudforet and others added 13 commits November 7, 2024 08:29
Signed-off-by: cloudforet-admin <[email protected]>
Signed-off-by: NaYeong,Kim <[email protected]>
* refactor: refactor dashboard store state management

Signed-off-by: samuel.park <[email protected]>

* chore: apply change dashboardInfo (getters -> state)

Signed-off-by: samuel.park <[email protected]>

* chore: apply review

Signed-off-by: samuel.park <[email protected]>

---------

Signed-off-by: samuel.park <[email protected]>
Signed-off-by: cloudforet-admin <[email protected]>
Copy link
Contributor

⚠️ @WANZARGEN the signed-off-by was not found in the following 2 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants