Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply additional feedback #5100

Closed
wants to merge 13 commits into from
Closed

Conversation

skdud4659
Copy link
Member

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

SSIA

Things to Talk About (optional)

skdud4659 and others added 13 commits November 20, 2024 10:31
* feat: apply PHeadingLayout

Signed-off-by: NaYeong,Kim <[email protected]>

* fix: fixed text clipping on select dropdown button

Signed-off-by: NaYeong,Kim <[email protected]>

---------

Signed-off-by: NaYeong,Kim <[email protected]>
about Custom Metric and Example

Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
fix: fix metricPage to distinguish between Admin Mode and User Mode
fix: fix reactivity issue for real-time LSB updates
* chore: update translations

Signed-off-by: NaYeong,Kim <[email protected]>

* fix: apply throw error

Signed-off-by: NaYeong,Kim <[email protected]>

* fix: apply is-fixed-width at select-dropdown

Signed-off-by: NaYeong,Kim <[email protected]>

---------

Signed-off-by: NaYeong,Kim <[email protected]>
Copy link
Contributor

⚠️ @skdud4659 the signed-off-by was not found in the following 2 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@skdud4659 skdud4659 closed this Nov 27, 2024
@skdud4659 skdud4659 deleted the feature-additional-feedback branch November 28, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants