Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix datatable footer bug (#5106) #5117

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

seungyeoneeee
Copy link
Contributor

  • fix: resolve groupby sum display issue in data table tf-col-format slot

  • fix: fix Total cell of datatable footer bug


To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

  • resolve groupby sum display issue in data table of CostAnalysis Page
    (after updated)
    image

  • fix Total cell of datatable footer bug of MetricAnalysis Page

Things to Talk About (optional)

* fix: resolve groupby sum display issue in data table tf-col-format slot

Signed-off-by: seungyeoneeee <[email protected]>

* fix: fix Total cell of datatable footer bug

Signed-off-by: seungyeoneeee <[email protected]>

---------

Signed-off-by: seungyeoneeee <[email protected]>
Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seungyeoneeee seungyeoneeee merged commit 5396f32 into master Nov 29, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants