feat: Update 1st feedback & userGroup markup 1st completed #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: seungyeoneeee <[email protected]>
Signed-off-by: 이승연 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Signed-off-by: 이승연 <[email protected]>
skdud4659
reviewed
Dec 10, 2024
| @@ -9,25 +9,36 @@ import type { UserGroupListItemType } from '@/schema/identity/user-group/type'; | |||
|
|
|||
| import type { ModalState } from '@/services/iam/types/user-group-type'; | |||
|
|
|||
| interface iState { | |||
There was a problem hiding this comment.
I think it would be good to align it by specifying the type using the store name!
Comment on lines
6
to
10
| const SCHEDULE_SETTING_LIST = [ | ||
| i18n.t('IAM.USER_GROUP.MODAL.CREATE_USER_GROUP.WEEKDAYS'), | ||
| i18n.t('IAM.USER_GROUP.MODAL.CREATE_USER_GROUP.EVERYDAY'), | ||
| i18n.t('IAM.USER_GROUP.MODAL.CREATE_USER_GROUP.CUSTOM'), | ||
| ]; |
There was a problem hiding this comment.
Does it work reactively when changing the translation?
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
seungyeoneeee
merged commit 6da7e3d
into
cloudforet-io:feature-project-alert-manager
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci, straightforward changes, etc.)Description (optional)
Things to Talk About (optional)