Feat: update about refreshing page after CRUD & mark-up about notification channel #5221
Conversation
Signed-off-by: seungyeoneeee <[email protected]>
Signed-off-by: seungyeoneeee <[email protected]>
Signed-off-by: seungyeoneeee <[email protected]>
Signed-off-by: seungyeoneeee <[email protected]>
Signed-off-by: seungyeoneeee <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Deployment failed with the following error: |
| { name: 'description', label: 'Description' }, | ||
| { name: 'notification', label: 'Notification' }, | ||
| { name: 'notification_channel', label: 'Notification Channel' }, // TODO: 따로 가져오기... |
There was a problem hiding this comment.
👀: It would be nice if comments were written in English, even if it's just a few.
| import { assetUrlConverter } from '@/lib/helper/asset-helper'; | ||
|
|
||
| // Temporary values | ||
| const state = reactive({ | ||
| channelList: [ | ||
| { | ||
| icon: 'ic_notification-protocol_envelope', | ||
| label: 'email', | ||
| label: i18n.t('IAM.USER_GROUP.MODAL.CREATE_CHANNEL.LIST.EMAIL'), |
There was a problem hiding this comment.
👀: Is this temporary data, and you even applied translations to it..? Is it going to be removed later?
|
|
||
| import { blue } from '@/styles/colors'; | ||
|
|
||
| const state = reactive({ |
There was a problem hiding this comment.
🤔: Last time, I created a component in the Alert Manager v2 folder. Can't we use that? If it's usable, I think it would be great to turn it into a common component for reuse.
| menuItems: MenuItem[] | ||
| } | ||
|
|
||
| const state = reactive({ |
There was a problem hiding this comment.
🤔: This looks like the same component as the one in Alert Manager v2. Could we make it into a reusable component?
| :deep(.p-text-input) { | ||
| width: 100%; | ||
| } | ||
|
|
||
| :deep(.p-select-dropdown) { | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
🤔: It would be best to minimize the use of deep in Mirinae as much as possible, and if customization is necessary, it would be good to add the item to Notion so it can be discussed during the Mirinae scrum.
Additionally, when we customize Mirinae components, we add comments like /* custom design-system component - p-context-menu */ so we can track and verify changes if the component gets updated later.
| title: '', | ||
| themeColor: 'Primary', | ||
| type: USER_GROUP_MODAL_TYPE.CREATE_NOTIFICATIONS_FIRST, | ||
| title: 'Create Notifications', |
There was a problem hiding this comment.
👀: Is it okay without the translation?
| @@ -28,14 +28,13 @@ const state = reactive({ | |||
| }); | |||
|
|
|||
| /* Component */ | |||
| const handleConfirm = () => { | |||
| const handleConfirm = async () => { | |||
| const deletePromises = storeState.selectedUserGroupIds.map((userGroupId) => fetchDeleteUserGroup({ | |||
There was a problem hiding this comment.
👀: Is it okay not to use await?
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
| const state = reactive({ | ||
| userMode: computed<MenuItem[]>(() => [{ | ||
| label: i18n.t('IAM.USER_GROUP.MODAL.CREATE_CHANNEL.DESC.USER_MODE.ALL_MEMBERS'), | ||
| name: 'allMembers', |
There was a problem hiding this comment.
👀: How about managing it as a constant to prevent human error?
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
Signed-off-by: 이승연 <[email protected]>
seungyeoneeee
merged commit fb79781
into
cloudforet-io:feature-project-alert-manager
To Reviewers
style,chore,ci, straightforward changes, etc.)Description (optional)
Things to Talk About (optional)