feat(dynamic-layout): add no-field case spec to Dynamic Layout(item-type) #5243
+127
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected the table entry for `fields` to reflect accurate options - Added detailed explanation and example for item type using `p-definition-table` component Signed-off-by: sulmo <[email protected]>
Signed-off-by: sulmo <[email protected]>
- Add computed property to check if fields are empty - Add computed property to check if root data is empty - Update fields computation based on new properties Signed-off-by: sulmo <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci, straightforward changes, etc.)Description (optional)
A new specification has been added to the Item Dynamic Layout, which previously did not function without the existing field option.
If the field option does not exist and the root data is in the form of an object, the object itself is displayed to fit the Item layout.
기존 field 옵션이 없으면 작동하지 않는 Item Dynamic Layout에 스펙이 추가되었습니다. field 옵션이 존재하지 않으면서 root data가 객체 형태로 존재하게 되면, 객체 자체를 Item 레이아웃에 맞게 보여줍니다.
Things to Talk About (optional)