Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix domain-specific access control for Advanced_Service #5268

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Dec 19, 2024

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

- Introduced `domainId` parameter to functions for domain-specific logic.
- Updated route redirection to consider `domainId`.
- Modified menu list selection based on `domainId` and alert manager version.
- Integrated domain store in various components and stores.

Signed-off-by: sulmo <[email protected]>
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:27am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 8:27am
hotfix2 ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 8:27am

@sulmoJ sulmoJ merged commit 03b46c2 into cloudforet-io:feature-project-alert-manager Dec 19, 2024
7 of 8 checks passed
@sulmoJ sulmoJ deleted the feature-project-alert-manager branch December 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant