Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from fix/lsb-width_workspace-navigation to master #5285

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

kkdy21
Copy link
Contributor

@kkdy21 kkdy21 commented Dec 20, 2024

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

daeyeon ko and others added 5 commits December 9, 2024 17:03
…avigation' into console/master

Signed-off-by: daeyeon ko <[email protected]>
…in metricLSB, verification message when adding a user (#5239)

* fix: display verification message after checking user search input

Signed-off-by: daeyeon ko <[email protected]>

* chore(language): en, jp, ko translation added

Signed-off-by: daeyeon ko <[email protected]>

* feat: enable the double-click option for verticalLayout

Signed-off-by: daeyeon ko <[email protected]>

* feat: minWidth spec added

Signed-off-by: daeyeon ko <[email protected]>

* fix: the width of metricExplorerLSB is not applied correctly

Signed-off-by: daeyeon ko <[email protected]>

* refactor: verticalLayout dbclick logic & apply LSB minWidth

Signed-off-by: daeyeon ko <[email protected]>

* fix: typo & type

Signed-off-by: daeyeon ko <[email protected]>

* refactor: use a hook to get the current menu ID

Signed-off-by: daeyeon ko <[email protected]>

* chore: remove unused variable

Signed-off-by: daeyeon ko <[email protected]>

---------

Signed-off-by: daeyeon ko <[email protected]>
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feature-itsm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:33am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Dec 20, 2024 9:33am
dashboard ⬜️ Ignored (Inspect) Dec 20, 2024 9:33am
hotfix2 ⬜️ Ignored (Inspect) Dec 20, 2024 9:33am
inventory-v2 ⬜️ Ignored (Inspect) Dec 20, 2024 9:33am

@kkdy21 kkdy21 merged commit 6b4475c into master Dec 20, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant