Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete unused widget helper and validation code #5288

Merged

Conversation

yuda110
Copy link
Member

@yuda110 yuda110 commented Dec 22, 2024

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

@yuda110 yuda110 requested a review from piggggggggy December 22, 2024 07:29
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2024 8:27am
dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2024 8:27am
hotfix2 ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2024 8:27am

Copy link
Member

@piggggggggy piggggggggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuda110 yuda110 force-pushed the feature/delte-unused branch from 6d08e90 to 6b63986 Compare December 22, 2024 08:24
@yuda110 yuda110 merged commit 90ad00e into cloudforet-io:feature-dashboard-november Dec 22, 2024
7 of 9 checks passed
@yuda110 yuda110 deleted the feature/delte-unused branch December 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants