Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DataSelector component for improved menu selection functionality #5376

Merged
merged 8 commits into from
Jan 2, 2025

Conversation

WANZARGEN
Copy link
Member

@WANZARGEN WANZARGEN commented Jan 2, 2025

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

image

Things to Talk About (optional)

- refactored useContextMenuController hook to use other context menu related hooks.
- Updated story helpers and added new stories for demonstration.
- Adjusted context menu item handling, including pagination and selection features.

Signed-off-by: Wanjin Noh <[email protected]>
@WANZARGEN WANZARGEN requested a review from piggggggggy January 2, 2025 07:54
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 9:38am
hotfix2 ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 9:38am

Copy link

vercel bot commented Jan 2, 2025

Deployment failed with the following error:

Preview deployments are disabled for this project.

@WANZARGEN
Copy link
Member Author

/preview

Copy link
Member

@piggggggggy piggggggggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Thanks~~!

Copy link

vercel bot commented Jan 2, 2025

@WANZARGEN is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

@WANZARGEN WANZARGEN merged commit 206ebcc into cloudforet-io:develop Jan 2, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants